Uploaded image for project: 'Funtoo Linux'
  1. Funtoo Linux
  2. FL-9497

metatools master and nextcloud: autogen failing

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Normal Normal
    • None
    • None

      When using metatools git master to autogen nextcloud, the following error is encountered:

      [ERROR 12:14:02] get_page() got an unexpected keyword argument 'encoding'
          Traceback (most recent call last):
            File "/home/drobbins/development/funtoo-metatools/funtoo/pkgtools/autogen.py", line 315, in gen_wrapper
              await generate(AutoHub(autogen_id, pkgtools), **pkginfo)
            File "/home/drobbins/development/kit-fixups/net-kit/curated/www-apps/nextcloud/autogen.py", line 9, in generate
              changelog_data = await hub.pkgtools.fetch.get_page(changelog_url, encoding="utf-8")
          TypeError: get_page() got an unexpected keyword argument 'encoding'
      [ERROR 12:14:02] get_page() got an unexpected keyword argument 'encoding'
          Traceback (most recent call last):
            File "/home/drobbins/development/funtoo-metatools/funtoo/pkgtools/autogen.py", line 322, in gen_wrapper
              raise te
            File "/home/drobbins/development/funtoo-metatools/funtoo/pkgtools/autogen.py", line 315, in gen_wrapper
              await generate(AutoHub(autogen_id, pkgtools), **pkginfo)
            File "/home/drobbins/development/kit-fixups/net-kit/curated/www-apps/nextcloud/autogen.py", line 9, in generate
              changelog_data = await hub.pkgtools.fetch.get_page(changelog_url, encoding="utf-8")
          TypeError: get_page() got an unexpected keyword argument 'encoding' 

      This is due to a refactoring of the fetch API in metatools git master. I have to investigate this two ways:

      1. Did this extra encoding= argument have any effect in the prior version of metatools? Is it still needed?
      2. In my refactor of get_page(), have I dropped something that ebuilds still need?

      In the fetch harness, there was some passing of extra arbitrary **kwargs around but this was undocumented by me so may have been accidentally wiped. I did find some areas where the **kwargs didn't seem to propagate to the right places so I assumed this functionality was not working. I may have been wrong.

            Unassigned Unassigned
            drobbins drobbins
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: