Uploaded image for project: 'Funtoo Linux'
  1. Funtoo Linux
  2. FL-10204

metatools: github tag_gen() could be more conservative

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Severe (Users) Severe (Users)
    • None
    • None
    • Our defaults for github.py's tag_gen() will likely cause future autogens to be too ambitious in trying to grab the most recent version from a list of tags. So this impacts potentially lots of future autogens if not fixed.

      As seemant experienced in FL-10195, github.py's tag_gen() can be overly grabby, using a regex of "([0-9.]+)" to try to grab a version from a tag, and this is not anchored at all to the start of the tag string, so "test_20201010" will extract a version of "20201010".

      It may be best to switch to a default regex of "^v?([0-9.]+)$". This anchors the regex, and looks for a version-y string that has an optional "v" prefix.

      This seems to be the standard "version tag" that upstreams are using, and would avoid accidentally grabbing numbers we probably aren't interested in.

      invakid404 please take a look and let me know your perspective.

            drobbins drobbins
            drobbins drobbins
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: